linux-kernel - Re: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150712062847.GA37026@dtor-ws>
Date:	Sat, 11 Jul 2015 23:28:47 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	HungNien Chen <hn.chen@...dahitech.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	charliemooney@...gle.com
Subject: Re: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms
 after the sw reset

On Sat, Jul 11, 2015 at 10:36:42PM +0800, HungNien Chen wrote:
>  The original value is 200ms, it includes the loading fw & boot up to
>  the main function. After that, the main function will do algorithm
>  initialized and touch calibrtion about 1.1 second. The touch
>  calibration will change controller freq to scan the best working freq 
>  and it has risk to make the i2c data error when doing fw update. 
>  We extend the sleep to 2500ms after the sw reset to skip this period time.
> 
> Signed-off-by: HungNien Chen <hn.chen@...dahitech.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/wdt87xx_i2c.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchscreen/wdt87xx_i2c.c
> index b97cb4f..cfd1487 100644
> --- a/drivers/input/touchscreen/wdt87xx_i2c.c
> +++ b/drivers/input/touchscreen/wdt87xx_i2c.c
> @@ -157,6 +157,7 @@
>  /* Controller requires minimum 300us between commands */
>  #define WDT_COMMAND_DELAY_MS		2
>  #define WDT_FLASH_WRITE_DELAY_MS	4
> +#define	WDT_FW_RESET_TIME		2500
>  
>  struct wdt87xx_sys_param {
>  	u16	fw_id;
> @@ -413,7 +414,7 @@ static int wdt87xx_sw_reset(struct i2c_client *client)
>  	}
>  
>  	/* Wait the device to be ready */
> -	msleep(200);
> +	msleep(WDT_FW_RESET_TIME);
>  
>  	return 0;
>  }
> -- 
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/