linux-kernel - Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACy=+Ds+pDd8oGg-7rOvZsDeHerRWAey2aYj8T00Ds1y67Z6kg@mail.gmail.com>
Date:	Sun, 12 Jul 2015 03:11:09 +0100
From:	Mustapha Abiola <hi@...tapha.org>
To:	eparis@...hat.com, paul@...l-moore.com,
	linux-kernel@...r.kernel.org, linux-audit@...hat.com,
	mingo@...hat.com
Subject: Subject: [PATCH 1/1] Fix redundant check against unsigned int in
 broken audit test fix for exec arg len

>From 55fae099d46749b73895934aab8c2823c5a23abe Mon Sep 17 00:00:00 2001

From: Mustapha Abiola <hi@...tapha.org>

Date: Sat, 11 Jul 2015 17:01:04 +0000

Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit
test fix for exec arg len


Quick patch to fix the needless check of `len` being < 0 as its an

unsigned int.


Signed-off-by: Mustapha Abiola <hi@...tapha.org>

---

 kernel/auditsc.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/kernel/auditsc.c b/kernel/auditsc.c

index e85bdfd..0012476 100644

--- a/kernel/auditsc.c

+++ b/kernel/auditsc.c

@@ -1021,7 +1021,7 @@ static int audit_log_single_execve_arg(struct
audit_context *context,

  * for strings that are too long, we should not have created

  * any.

  */

- if (WARN_ON_ONCE(len < 0 || len > MAX_ARG_STRLEN - 1)) {

+ if (WARN_ON_ONCE(len > MAX_ARG_STRLEN - 1)) {

  send_sig(SIGKILL, current, 0);

  return -1;

  }

-- 

1.9.1

Download attachment "0001-Fix-redundant-check-against-unsigned-int-in-broken-a.patch" of type "application/octet-stream" (930 bytes)