linux-kernel - Re: [alsa-devel] [PATCH v3] ASoC: Add support for NAU8825 codec to ASoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1436779390.2533.20.camel@loki>
Date:	Mon, 13 Jul 2015 10:23:10 +0100
From:	Liam Girdwood <liam.r.girdwood@...ux.intel.com>
To:	Chih-Chiang Chang <ccchang12@...oton.com>
Cc:	Mark Brown <broonie@...nel.org>, "tiwai@...e.de" <tiwai@...e.de>,
	AP MS30 Linux ALSA <alsa-devel@...a-project.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	AP MS30 Linux Kernel community 
	<linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH v3] ASoC: Add support for NAU8825 codec to
 ASoC

On Mon, 2015-07-13 at 15:33 +0800, Chih-Chiang Chang wrote:
> +static void set_sys_clk(struct snd_soc_codec *codec, int sys_clk)
> +{
> +    struct nau8825_priv *nau8825 = snd_soc_codec_get_drvdata(codec);
> +
> +    pr_debug("%s :: sys_clk=%x\n", __func__, sys_clk);
> +    switch (sys_clk) {
> +    case NAU8825_INTERNALCLOCK:
> +        regmap_update_bits(nau8825->regmap, NAU8825_CLK_DIVIDER,
> +                NAU8825_SYSCLK_EN_MASK, NAU8825_SYSCLK_DIS);
> +        regmap_update_bits(nau8825->regmap, NAU8825_FLL_6,
> +                NAU8825_DCO_EN_MASK, NAU8825_DCO_EN);
> +        regmap_update_bits(nau8825->regmap, NAU8825_CLK_DIVIDER,
> +                NAU8825_SYSCLK_EN_MASK, NAU8825_SYSCLK_EN);
> +        break;
> +    case NAU8825_MCLK:
> +    default:
> +        regmap_update_bits(nau8825->regmap, NAU8825_FLL_6,
> +                NAU8825_DCO_EN_MASK, NAU8825_DCO_DIS);
> +        regmap_update_bits(nau8825->regmap, NAU8825_I2S_PCM_CTRL_2,
> +                NAU8825_I2S_MS_MASK, NAU8825_I2S_MS_SLAVE);
> +        /* FLL clock source from MCLK */
> +        regmap_update_bits(nau8825->regmap, NAU8825_CLK_DIVIDER,
> +                NAU8825_SYSCLK_EN_MASK, NAU8825_SYSCLK_DIS);
> +        mdelay(2);

Probably best to sleep here rather than block, especially if this code
will be used in init/PM sequences.

Btw, is there anyway to check whether the FLL actually achieves lock
after the 2ms ?

> +        regmap_update_bits(nau8825->regmap, NAU8825_CLK_DIVIDER,
> +                NAU8825_SYSCLK_EN_MASK, NAU8825_SYSCLK_EN);
> +        break;
> +    }
> +}
> +

Thanks

Liam


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/