linux-kernel - Re: [PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific linkage.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jul 2015 11:08:12 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Ralf Baechle <ralf@...ux-mips.org>
CC:	Andrew Bresticker <abrestic@...omium.org>,
	<linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific
 linkage.h

On 13/07/15 00:12, Bjorn Helgaas wrote:
> "__weak" is defined in include/linux/compiler-gcc.h.  We shouldn't need an
> arch-specific definition.
> 
> Remove the "__weak" definition from arch/mips/include/asm/linkage.h.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

asm/linkage.h is only included from linux/linkage.h, which includes
linux/compiler.h first, so no chance of build problems AFAICT, therefore:

Reviewed-by: James Hogan <james.hogan@...tec.com>

Thanks
James

> ---
>  arch/mips/include/asm/linkage.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/linkage.h b/arch/mips/include/asm/linkage.h
> index 2767dda..99651b0 100644
> --- a/arch/mips/include/asm/linkage.h
> +++ b/arch/mips/include/asm/linkage.h
> @@ -5,7 +5,6 @@
>  #include <asm/asm.h>
>  #endif
>  
> -#define __weak __attribute__((weak))
>  #define cond_syscall(x) asm(".weak\t" #x "\n" #x "\t=\tsys_ni_syscall")
>  #define SYSCALL_ALIAS(alias, name)					\
>  	asm ( #alias " = " #name "\n\t.globl " #alias)
> 


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)