[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <55A3AF9F.6050508@samsung.com>
Date: Mon, 13 Jul 2015 14:31:27 +0200
From: Jacek Anaszewski <j.anaszewski@...sung.com>
To: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc: Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>,
"open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: Drop owner assignment from i2c_driver
Hi Krzysztof,
Thanks for the patch.
On 07/10/2015 08:00 AM, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
> drivers/leds/leds-lm3530.c | 1 -
> drivers/leds/leds-lm355x.c | 1 -
> drivers/leds/leds-lm3642.c | 1 -
> drivers/leds/leds-pca955x.c | 1 -
> drivers/leds/leds-pca963x.c | 1 -
> drivers/leds/leds-tca6507.c | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
> index 91325de3cd33..b38430cb10ad 100644
> --- a/drivers/leds/leds-lm3530.c
> +++ b/drivers/leds/leds-lm3530.c
> @@ -492,7 +492,6 @@ static struct i2c_driver lm3530_i2c_driver = {
> .id_table = lm3530_id,
> .driver = {
> .name = LM3530_NAME,
> - .owner = THIS_MODULE,
> },
> };
>
> diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c
> index f5112cb2d991..48872997d6b4 100644
> --- a/drivers/leds/leds-lm355x.c
> +++ b/drivers/leds/leds-lm355x.c
> @@ -555,7 +555,6 @@ MODULE_DEVICE_TABLE(i2c, lm355x_id);
> static struct i2c_driver lm355x_i2c_driver = {
> .driver = {
> .name = LM355x_NAME,
> - .owner = THIS_MODULE,
> .pm = NULL,
> },
> .probe = lm355x_probe,
> diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
> index d3dec0132769..02ebe342f5af 100644
> --- a/drivers/leds/leds-lm3642.c
> +++ b/drivers/leds/leds-lm3642.c
> @@ -446,7 +446,6 @@ MODULE_DEVICE_TABLE(i2c, lm3642_id);
> static struct i2c_driver lm3642_i2c_driver = {
> .driver = {
> .name = LM3642_NAME,
> - .owner = THIS_MODULE,
> .pm = NULL,
> },
> .probe = lm3642_probe,
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index c3a08b60535b..b775e1efecd3 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -379,7 +379,6 @@ static int pca955x_remove(struct i2c_client *client)
> static struct i2c_driver pca955x_driver = {
> .driver = {
> .name = "leds-pca955x",
> - .owner = THIS_MODULE,
> },
> .probe = pca955x_probe,
> .remove = pca955x_remove,
> diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
> index bee3e1ab27fd..3f63a1bfdc4f 100644
> --- a/drivers/leds/leds-pca963x.c
> +++ b/drivers/leds/leds-pca963x.c
> @@ -458,7 +458,6 @@ static int pca963x_remove(struct i2c_client *client)
> static struct i2c_driver pca963x_driver = {
> .driver = {
> .name = "leds-pca963x",
> - .owner = THIS_MODULE,
> .of_match_table = of_match_ptr(of_pca963x_match),
> },
> .probe = pca963x_probe,
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index 20fa8e77f186..c1f910981781 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -830,7 +830,6 @@ static int tca6507_remove(struct i2c_client *client)
> static struct i2c_driver tca6507_driver = {
> .driver = {
> .name = "leds-tca6507",
> - .owner = THIS_MODULE,
> .of_match_table = of_match_ptr(of_tca6507_leds_match),
> },
> .probe = tca6507_probe,
>
Acked-by: Jacek Anaszewski <j.anaszewski@...sung.com>
--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists