linux-kernel - Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1507131443460.1713@denkbrett>
Date:	Mon, 13 Jul 2015 14:47:17 +0200 (CEST)
From:	Sebastian Ott <sebott@...ux.vnet.ibm.com>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Grant Likely <grant.likely@...aro.org>,
	Marc Zyngier <marc.zyngier@....com>,
	Stuart Yoder <stuart.yoder@...escale.com>,
	Yijing Wang <wangyijing@...wei.com>,
	Borislav Petkov <bp@...en8.de>,
	Gerald Schaefer <gerald.schaefer@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux390@...ibm.com, Tony Luck <tony.luck@...el.com>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-s390@...r.kernel.org
Subject: Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access
 MSI device list

On Thu, 9 Jul 2015, Jiang Liu wrote:

> Use accessor for_pci_msi_entry() to access MSI device list, so we could
> easily move msi_list from struct pci_dev into struct device later.
> 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>

Acked-by: Sebastian Ott <sebott@...ux.vnet.ibm.com>

Regards,
Sebastian

> ---
>  arch/s390/pci/pci.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c
> index 598f023cf8a6..34f162753403 100644
> --- a/arch/s390/pci/pci.c
> +++ b/arch/s390/pci/pci.c
> @@ -414,7 +414,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
> 
>  	/* Request MSI interrupts */
>  	hwirq = 0;
> -	list_for_each_entry(msi, &pdev->msi_list, list) {
> +	for_each_pci_msi_entry(msi, pdev) {
>  		rc = -EIO;
>  		irq = irq_alloc_desc(0);	/* Alloc irq on node 0 */
>  		if (irq < 0)
> @@ -440,7 +440,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
>  	return (msi_vecs == nvec) ? 0 : msi_vecs;
> 
>  out_msi:
> -	list_for_each_entry(msi, &pdev->msi_list, list) {
> +	for_each_pci_msi_entry(msi, pdev) {
>  		if (hwirq-- == 0)
>  			break;
>  		irq_set_msi_desc(msi->irq, NULL);
> @@ -470,7 +470,7 @@ void arch_teardown_msi_irqs(struct pci_dev *pdev)
>  		return;
> 
>  	/* Release MSI interrupts */
> -	list_for_each_entry(msi, &pdev->msi_list, list) {
> +	for_each_pci_msi_entry(msi, pdev) {
>  		if (msi->msi_attrib.is_msix)
>  			__pci_msix_desc_mask_irq(msi, 1);
>  		else
> -- 
> 1.7.10.4
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/