linux-kernel - Re: [PATCH 1/2] Add NXP LPC32XX SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55A3AE66.1070705@cdi.cz>
Date:	Mon, 13 Jul 2015 14:26:14 +0200
From:	Martin Devera <martin.devera@....cz>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Add NXP LPC32XX SPI driver

Paul Bolle wrote:
> (This hit my box with lkml mesages without lkml in the To: header. What
> happened here?)

Ahh, have to check my sending script ..

> On zo, 2015-07-12 at 11:20 +0200, Martin Devera wrote:
>> --- /dev/null
>> +++ b/drivers/spi/spi-lpc32xx.c
> 
>> +#define DRIVER_NAME	"spi-lpc32xx"
> 
>> +MODULE_ALIAS("platform:" DRIVER_NAME);
> 
> This alias seems only useful if there's a corresponding struct
> platform_device. Ie, a struct platform_device with a .name of "spi
> -lpc32xx", which will fire off a "MODALIAS=platform:spi-lpc32xx" uevent
> when it's created.

My fault, thanks for spotting. It is leftover from driver I used
as template...
In any case, I has other comments from Joachim Eastwood thus I plan
to do more cleanup and resubmit the driver later..

thanks,
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/