linux-kernel - Re: [PATCH v2 01/13] ARM: kill off set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150713031901.GM23464@tiger>
Date:	Mon, 13 Jul 2015 11:19:01 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Rob Herring <robh@...nel.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Andrew Lunn <andrew@...n.ch>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	Sekhar Nori <nsekhar@...com>, Greg Ungerer <gerg@...inux.org>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Roland Stigge <stigge@...com.de>,
	linux-samsung-soc@...r.kernel.org,
	Tony Lindgren <tony@...mide.com>, arm@...nel.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Jason Cooper <jason@...edaemon.net>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	linux-omap@...r.kernel.org, Simtec Linux Team <linux@...tec.co.uk>,
	Shawn Guo <shawn.guo@...aro.org>, linux-kernel@...r.kernel.org,
	Kukjin Kim <kgene@...nel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Imre Kaloz <kaloz@...nwrt.org>, Daniel Mack <daniel@...que.org>
Subject: Re: [PATCH v2 01/13] ARM: kill off set_irq_flags usage

On Sun, Jul 12, 2015 at 09:26:39AM -0500, Rob Herring wrote:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
> 
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
> 
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Sekhar Nori <nsekhar@...com>
> Cc: Kevin Hilman <khilman@...prootsystems.com>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Gregory Clement <gregory.clement@...e-electrons.com>
> Acked-by: Hans Ulli Kroll <ulli.kroll@...glemail.com>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Sascha Hauer <kernel@...gutronix.de>
> Cc: Imre Kaloz <kaloz@...nwrt.org>
> Acked-by: Krzysztof Halasa <khalasa@...p.pl>
> Cc: Greg Ungerer <gerg@...inux.org>
> Cc: Roland Stigge <stigge@...com.de>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Daniel Mack <daniel@...que.org>
> Cc: Haojian Zhuang <haojian.zhuang@...il.com>
> Cc: Robert Jarzmik <robert.jarzmik@...e.fr>
> Cc: Simtec Linux Team <linux@...tec.co.uk>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Acked-by: Wan ZongShun <mcuos.com@...il.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-omap@...r.kernel.org
> Cc: linux-samsung-soc@...r.kernel.org
> Tested-by: Kevin Hilman <khilman@...aro.org>
> ---
...
>  arch/arm/mach-imx/3ds_debugboard.c   |  2 +-
>  arch/arm/mach-imx/mach-mx31ads.c     |  2 +-

Acked-by: Shawn Guo <shawnguo@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/