[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150713032303.D49801402B1@ozlabs.org>
Date: Mon, 13 Jul 2015 13:23:03 +1000 (AEST)
From: Michael Ellerman <mpe@...erman.id.au>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>
Cc: linux-arch@...r.kernel.org, linux-mips@...ux-mips.org,
linux-am33-list@...hat.com, linux-ia64@...r.kernel.org,
linux-c6x-dev@...ux-c6x.org, linux-parisc@...r.kernel.org,
linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
adi-buildroot-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
linux-alpha@...r.kernel.org, x86@...nel.org,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures
On Sun, 2015-12-07 at 22:02:11 UTC, Bjorn Helgaas wrote:
> Many architectures use a variant of "unexpected IRQ trap at vector %x" to
> log unexpected IRQs. This is confusing because (a) it prints the Linux IRQ
> number, but "vector" more often refers to a CPU vector number, and (b) it
> prints the IRQ number in hex with no base indication, while Linux IRQ
> numbers are usually printed in decimal.
>
> Print the same text ("unexpected IRQ %d") across all architectures.
>
> No functional change other than the output text.
There's already a fallback version in asm-generic, so shouldn't you instead
just delete all the versions that are identical to that?
eg. on powerpc we have:
> static inline void ack_bad_irq(unsigned int irq)
> {
> - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq);
> + printk(KERN_CRIT "unexpected IRQ %d\n", irq);
> }
And the generic version is:
> #ifndef ack_bad_irq
> static inline void ack_bad_irq(unsigned int irq)
> {
> - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq);
> + printk(KERN_CRIT "unexpected IRQ %d\n", irq);
> }
> #endif
So we can just delete the powerpc version?
cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists