linux-kernel - Re: [PATCH] trace-cmd: annotate function durations like the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150713144319.393b5015@gandalf.local.home>
Date:	Mon, 13 Jul 2015 14:43:19 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Omar Sandoval <osandov@...com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trace-cmd: annotate function durations like the kernel

On Wed, 24 Jun 2015 11:36:54 -0700
Omar Sandoval <osandov@...com> wrote:

> Since kernel commit, 8e1e1df29d83 ("tracing: Add additional marks to
> signal very large time deltas") the kernel annotates durations longer
> than 1000 usecs with # and longer than 1 sec with $. Update trace-cmd
> report to be consistent with it.


Thanks, applied.

(sorry for the late notice). I'll be pushing this up later today.

-- Steve

> 
> Signed-off-by: Omar Sandoval <osandov@...com>
> ---
> Just a minor cosmetic issue I noticed. Thanks!
> 
>  trace-ftrace.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/trace-ftrace.c b/trace-ftrace.c
> index bdf11ce4c2dd..636b08b5cdef 100644
> --- a/trace-ftrace.c
> +++ b/trace-ftrace.c
> @@ -147,11 +147,19 @@ static void print_graph_overhead(struct trace_seq *s,
>  	if (duration == ~0ULL)
>  		return (void)trace_seq_printf(s, "  ");
>  
> -	/* Duration exceeded 100 msecs */
> +	/* Duration exceeded 1 sec */
> +	if (duration > 1000000000ULL)
> +		return (void)trace_seq_printf(s, "$ ");
> +
> +	/* Duration exceeded 1000 usecs */
> +	if (duration > 1000000ULL)
> +		return (void)trace_seq_printf(s, "# ");
> +
> +	/* Duration exceeded 100 usecs */
>  	if (duration > 100000ULL)
>  		return (void)trace_seq_printf(s, "! ");
>  
> -	/* Duration exceeded 10 msecs */
> +	/* Duration exceeded 10 usecs */
>  	if (duration > 10000ULL)
>  		return (void)trace_seq_printf(s, "+ ");
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/