linux-kernel - RE: [PATCH RFC V3 3/5] perf,tool: partial time support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0770188BEF4@SHSMSX103.ccr.corp.intel.com>
Date:	Mon, 13 Jul 2015 19:01:51 +0000
From:	"Liang, Kan" <kan.liang@...el.com>
To:	'Namhyung Kim' <namhyung@...nel.org>
CC:	"acme@...nel.org" <acme@...nel.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hunter, Adrian" <adrian.hunter@...el.com>
Subject: RE: [PATCH RFC V3 3/5] perf,tool: partial time support

> Hi,
> 
> (CC-ing Adrian)
> 
> On Wed, Jul 08, 2015 at 04:44:55AM -0400, kan.liang@...el.com wrote:
> > From: Kan Liang <kan.liang@...el.com>
> >
> > When multiple events are sampled it may not be needed to collect fine
> > grained time stamps on all events. The sample sites are usually nearby.
> > It's enough to have time stamps on the regular reference events.
> > This patchkit adds the ability to turn off time stamps per event. This
> > in term can reduce sampling overhead and the size of the perf.data.
> 
> So this patch makes the PERF_SAMPLE_TIME bit set or not independently,
> right?  But AFAIK we sometimes just use first evsel for checking
> sample_type value, especially for evlist->id_pos.  I'm not sure it'll work for
> all cases of mixed time/notime events..
>

If the sample_type is different, IDENTIFIER will be set to make sure id is in
a fixed position. So we don't need to worry about evlist->id_pos here.

I think the only unsupported case should be that the kernel doesn't
support IDENTIFIER.  If so, under my test, perf record will print warning
" failed to process type". Perf report will also print warning
" non matching sample_type". So the user can switch back to full time
support.
If you think the warning is not good enough, we can show specific
warning and error out when non IDENTIFIER support is detected.

Thanks,
Kan