linux-kernel - Re: [PATCH 2/4] dt-bindings: soc: Add documentation for the MediaTek SCPSYS unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS+omBt+0+pQ4P2kRqVOB5XJFB2BxgCcPn=j4MNVMYLY4TvBg@mail.gmail.com>
Date:	Mon, 13 Jul 2015 12:51:50 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
	Kevin Hilman <khilman@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mediatek@...ts.infradead.org,
	Sasha Hauer <kernel@...gutronix.de>,
	Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 2/4] dt-bindings: soc: Add documentation for the MediaTek
 SCPSYS unit

On Wed, Jun 24, 2015 at 2:17 PM, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> This adds documentation for the MediaTek SCPSYS unit found in MT8173 SoCs.
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>  .../devicetree/bindings/soc/mediatek/scpsys.txt    | 41 ++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> new file mode 100644
> index 0000000..c051114
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> @@ -0,0 +1,41 @@
> +MediaTek SCPSYS
> +===============
> +
> +The System Control Processor System (SCPSYS) has several power management
> +related tasks in the system. The tasks include thermal measurement, dynamic
> +voltage frequency scaling (DVFS), interrupt filter and lowlevel sleep control.
> +The System Power Manager (SPM) inside the SCPSYS is for the MTCMOS power
> +domain control.
> +
> +The driver implements the Generic PM domain bindings described in
> +power/power_domain.txt. It provides the power domains defined in
> +include/dt-bindings/power/mt8173-power.h.
> +
> +Required properties:
> +- compatible: Must be "mediatek,mt8173-scpsys"
> +- #power-domain-cells: Must be 1
> +- reg: Address range of the SCPSYS unit
> +- infracfg: must contain a phandle to the infracfg controller
> +- clock, clock-names: clocks according to the common clock binding.
> +                      The clocks needed "mm" and "mfg". These are the
> +                     clocks which hardware needs to be enabled before
> +                     enabling certain power domains.
> +
> +Example:
> +
> +       scpsys: scpsys@...06000 {

Perhaps it is too late, and/or too pedantic, but, since this node
defines a PM domain provider as defined in [0], shouldn't its node
have been the more generic:

  scpsys: power-controller@...06000

[0] /Documentation/devicetree/bindings/power/power_domain.txt

> +               #power-domain-cells = <1>;
> +               compatible = "mediatek,mt8173-scpsys";
> +               reg = <0 0x10006000 0 0x1000>;
> +               infracfg = <&infracfg>;
> +               clocks = <&clk26m>,
> +                        <&topckgen CLK_TOP_MM_SEL>;
> +               clock-names = "mfg", "mm";
> +       };
> +
> +Example consumer:
> +
> +       afe: mt8173-afe-pcm@...20000 {
> +               compatible = "mediatek,mt8173-afe-pcm";
> +               power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
> +       };
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/