linux-kernel - Re: [PATCH RFC] x86: enforce inlining for atomics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <152440796.1623.1436821948088.JavaMail.open-xchange@ox1app>
Date:	Mon, 13 Jul 2015 23:12:27 +0200 (CEST)
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH RFC] x86: enforce inlining for atomics

> On July 13, 2015 at 11:06 PM Denys Vlasenko <vda.linux@...glemail.com>
> wrote:
>
> Not *your* way.
> I meant that I'll send patches to Ingo - I see that he agrees that
> this worth fixing instead of waiting for a better compiler.

Yeah, do it. Sorry it was not my intention to prevent you to fix this -
not at all. Go on, *every* patch will make things better.

> (Ideally, the compiler shouldn't do this, but gcc BZ comments
> are not encouraging).

Right, the inline heuristic - as Linus already noted - is quite bad for
some cases (especially inline asm).

Hagen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/