linux-kernel - Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A4C702.9070005@amd.com>
Date:	Tue, 14 Jul 2015 10:23:30 +0200
From:	Christian König <christian.koenig@....com>
To:	Alexander Kuleshov <kuleshovmail@...il.com>,
	Alex Deucher <alexdeucher@...il.com>
CC:	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>,
	Jammy Zhou <Jammy.Zhou@....com>, yanyang1 <young.yang@....com>,
	Marek Olšák <marek.olsak@....com>,
	Maninder Singh <maninder1.s@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Maling list - DRI developers" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS
 is set

On 14.07.2015 10:18, Alexander Kuleshov wrote:
> Hello Alex,
>
> 2015-07-14 11:11 GMT+06:00 Alex Deucher <alexdeucher@...il.com>:
>> This patch breaks the build with debugfs enabled.
>>
> I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds
> successfully. Did I miss something?
> Maybe I need to enable/disable anything else CONFIG_*?

Price question is why do you want to conditionally include this header 
in the first place?

If the kernel isn't build with CONFIG_DEBUG_FS we shouldn't use the 
defines, but otherwise they don't seem to hurt.

Regards,
Christian.

>
> Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/