linux-kernel - [PATCH v2] cfg80211-wext: deleting dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2015 08:46:43 +0000 (GMT)
From:	Rahul Jain <rahul.jain@...sung.com>
To:	Rafa? Mi?ecki <zajec5@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Johannes Berg <johannes.berg@...el.com>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Nitin Jhanwar <nitin.j@...sung.com>,
	HEMANSHU SRIVASTAVA <hemanshu.s@...sung.com>,
	Amit Khatri <amit.khatri@...sung.com>
Subject: [PATCH v2] cfg80211-wext: deleting dead code

From e945737ef2e3a5b7198b9795d6375de85b2fac08 Mon Sep 17 00:00:00 2001
From: Rahul Jain <rahul.jain@...sung.com>
Date: Tue, 14 Jul 2015 14:04:09 +0530
Subject: [PATCH] cfg80211-wext: deleting dead code

In func cfg80211_wext_siwretry(), the value of changed is getting
modified to non-zero value within if-else condition and it is becoming a non-zero value.
So, the condition "if (!changed)" becomes unreachable.

Signed-off-by: Rahul Jain <rahul.jain@...sung.com>
Signed-off-by: Amit Khatri <amit.khatri@...sung.com>
---
 net/wireless/wext-compat.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c
index fd68283..8de1b64 100644
--- a/net/wireless/wext-compat.c
+++ b/net/wireless/wext-compat.c
@@ -387,9 +387,6 @@ static int cfg80211_wext_siwretry(struct net_device *dev,
 		changed |= WIPHY_PARAM_RETRY_SHORT;
 	}
 
-	if (!changed)
-		return 0;
-
 	err = rdev_set_wiphy_params(rdev, changed);
 	if (err) {
 		wdev->wiphy->retry_short = oshort;
-- 
1.9.1

------- Original Message -------
Sender : Rafa? Mi?ecki<zajec5@...il.com>
Date : Jul 14, 2015 01:28 (GMT+05:30)
Title : Re: [PATCH] Logically DeadCode

On 3 July 2015 at 06:52, Rahul Jain wrote:
> From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001
> From: Rahul Jain 
> Date: Fri, 3 Jul 2015 10:19:12 +0530
> Subject: [PATCH] Logically DeadCode

You didn't use any prefix for the commit message, it's unclear
(Logically DeadCode what?), no description, you touch two code places
at once.

Please fix above problems and resend.