linux-kernel - Re: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1436867199.9416.16.camel@mtksdaap41>
Date:	Tue, 14 Jul 2015 17:46:39 +0800
From:	James Liao <jamesjj.liao@...iatek.com>
To:	Daniel Kurtz <djkurtz@...omium.org>
CC:	Matthias Brugger <matthias.bgg@...il.com>,
	Mike Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"Heiko Stubner" <heiko@...ech.de>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Ricky Liang <jcliang@...omium.org>,
	Rob Herring <robh+dt@...nel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173
 APMIXEDSYS

Hi Daniel,

On Tue, 2015-07-14 at 11:23 +0800, Daniel Kurtz wrote:
> On Tue, Jul 14, 2015 at 10:45 AM, James Liao <jamesjj.liao@...iatek.com> wrote:
> > On Mon, 2015-07-13 at 22:46 +0800, Daniel Kurtz wrote:
> >> > +static const struct clk_ops mtk_ref2usb_tx_ops = {
> >> > +       .is_prepared    = mtk_ref2usb_tx_is_prepared,
> >> > +       .prepare        = mtk_ref2usb_tx_prepare,
> >> > +       .unprepare      = mtk_ref2usb_tx_unprepare,
> >> > +};
> >>
> >> Burying the implementation of this special "mtk_ref2usb" clock in
> >> clk-mt8173,c seems a bit awkward.
> >> Can you please move it to its own file, like mediatek/clk-usb.c?
> >
> > Do you mean clk/mediatek/clk-usb.c?
> >
> > This clock is a MT8173 specific clock, which may not be reused by other
> > SoCs. So I think it's not necessary to move it to a separated file.
> 
> Yes, this is a wrapper for a type of clock.  I think it would be
> better in its own file, rather than embedded in clk-mt8173.c, which is
> more about enumerating and initializing the clock tree.
> 
> Perhaps today it is only used for mt8173, but that may not be the case
> in the future.

OK, I'll separate it from clk-mt8173.c.

Ref2usb_tx's control register is located in APMIXEDSYS, which contains
most of PLL controlling. Is this clock suitable to implemented
mtk-pll.c? Or it's proper to be a separated file such as clk-usb.c?


Best regards,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/