linux-kernel - Re: [PATCH v2 42/48] usb: gadget: epautoconf: use 'ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A4ECC0.4030205@cogentembedded.com>
Date:	Tue, 14 Jul 2015 14:04:32 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Robert Baldyga <r.baldyga@...sung.com>, gregkh@...uxfoundation.org,
	balbi@...com
Cc:	Peter.Chen@...escale.com, johnyoun@...opsys.com,
	dahlmann.thomas@...or.de, nicolas.ferre@...el.com,
	cernekee@...il.com, leoli@...escale.com, daniel@...que.org,
	haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
	michal.simek@...inx.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-geode@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	linuxppc-dev@...ts.ozlabs.org, andrzej.p@...sung.com,
	m.szyprowski@...sung.com
Subject: Re: [PATCH v2 42/48] usb: gadget: epautoconf: use 'ep_match' gadget
 callback

Hello.

On 7/14/2015 12:39 PM, Robert Baldyga wrote:

> If gadget has set 'ep_match' callback we prefer to call it first to allow
> UDC driver to find the best matching endpoint basing on chip-specific "best
> usage" knowledge.

> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> ---
>   drivers/usb/gadget/epautoconf.c | 6 ++++++
>   1 file changed, 6 insertions(+)

> diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c
> index ee0d4e6..92a1a4c 100644
> --- a/drivers/usb/gadget/epautoconf.c
> +++ b/drivers/usb/gadget/epautoconf.c
> @@ -165,6 +165,12 @@ struct usb_ep *usb_ep_autoconfig_ss(
>
>   	type = desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK;
>
> +	if (gadget->ops->match_ep) {
> +		ep = gadget->ops->match_ep(gadget, desc, ep_comp);
> +		if (ep)
> +			goto found_ep;
> +	}
> +

    I think this patch should be merged with the previous one.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/