linux-kernel - Re: [PATCH-v4 06/11] i2c:pxa: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150714113556.GE1517@katana>
Date:	Tue, 14 Jul 2015 13:35:57 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Vaibhav Hiremath <vaibhav.hiremath@...aro.org>
Cc:	linux-i2c@...r.kernel.org, robh+dt@...nel.org,
	robert.jarzmik@...e.fr, yizhang@...vell.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

> +	i2c->reg_base = devm_ioremap_resource(&dev->dev, res);
> +	if (IS_ERR(i2c->reg_base)) {
> +		dev_err(&dev->dev, "failed to map resource: %ld\n",
> +			PTR_ERR(i2c->reg_base));
> +		return PTR_ERR(i2c->reg_base);
> +	}

One change I did when applying: removed this error message.
devm_ioremap_resource prints out the errors it finds.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)