[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1436880105.11226.2.camel@sipsolutions.net>
Date: Tue, 14 Jul 2015 15:21:45 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Larry Finger <Larry.Finger@...inger.net>,
Bastien Nocera <hadess@...ess.net>,
"David S. Miller" <davem@...emloft.net>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT
On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote:
> On 07/13/2015 05:11 PM, Bastien Nocera wrote:
> > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/
> > focu
> > s=127896
> >
> > Signed-off-by: Bastien Nocera <hadess@...ess.net>
>
> Bastien,
>
> The subject of this patch needs a bit more detail. I know that you
> mean the
> RTL8723B versions of the Bluetooth devices. The subject should say
> this.
>
> The commit message needs a bit more detail. Referencing the E-mail
> thread is OK,
> but a bit more is needed. What fails without this change?
>
> To help keep that patches straight, change the next submission to say
> "[PATCH
> V2]" in the subject. In addition, after the ---, add a section saying
> what
> changed in V2. That info is not retained in the final commit message
> in the
> repo, but it can be very useful to a maintainer.
>
And while at it, please use links that include the message-id (e.g.
mid.gmane.org) so it's searchable even if the archive disappears.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists