linux-kernel - Re: [PATCH 1/4] change get_super_thawed() to use sb_start/end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150714133825.GB24837@redhat.com>
Date:	Tue, 14 Jul 2015 15:38:25 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Daniel Wagner <daniel.wagner@...-carit.de>,
	Davidlohr Bueso <dave@...olabs.net>,
	Ingo Molnar <mingo@...hat.com>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] change get_super_thawed() to use
	sb_start/end_write()

On 07/14, Jan Kara wrote:
>
> > @@ -621,8 +621,8 @@ struct super_block *get_super_thawed(struct block_device *bdev)
> >  		if (!s || s->s_writers.frozen == SB_UNFROZEN)
> >  			return s;
> >  		up_read(&s->s_umount);
> > -		wait_event(s->s_writers.wait_unfrozen,
> > -			   s->s_writers.frozen == SB_UNFROZEN);
> > +		sb_start_write(s);
> > +		sb_end_intwrite(s);
>
> This is definitely buggy - you need to start and end freeze protection at
> the same level...

Of course ;) copy-and-paste bug. Thanks!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/