linux-kernel - Re: Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len

Open Source and information security mailing list archives

Message-ID: <20150714142454.GA29053@madcap2.tricolour.ca>
Date:	Tue, 14 Jul 2015 10:24:54 -0400
From:	Richard Guy Briggs <rgb@...hat.com>
To:	Mustapha Abiola <hi@...tapha.org>
Cc:	paul@...l-moore.com, linux-kernel@...r.kernel.org,
	linux-audit@...hat.com
Subject: Re: Subject: [PATCH 1/1] Fix redundant check against unsigned int in
 broken audit test fix for exec arg len

On 15/07/12, Mustapha Abiola wrote:
> >From 55fae099d46749b73895934aab8c2823c5a23abe Mon Sep 17 00:00:00 2001
> From: Mustapha Abiola <hi@...tapha.org>
> Date: Sat, 11 Jul 2015 17:01:04 +0000
> Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len
> 
> Quick patch to fix the needless check of `len` being < 0 as its an unsigned int.

If you are able, it is much easier to use "git format-patch ..." and
"git send-email ...".  Something in your workflow is double-spacing your
message...  I echo Paul's recommendation...

> Signed-off-by: Mustapha Abiola <hi@...tapha.org>
> 
> ---
> 
>  kernel/auditsc.c | 2 +-
> 
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> 
> index e85bdfd..0012476 100644
> 
> --- a/kernel/auditsc.c
> 
> +++ b/kernel/auditsc.c
> 
> @@ -1021,7 +1021,7 @@ static int audit_log_single_execve_arg(struct
> audit_context *context,
> 
>   * for strings that are too long, we should not have created
> 
>   * any.
> 
>   */
> 
> - if (WARN_ON_ONCE(len < 0 || len > MAX_ARG_STRLEN - 1)) {
> 
> + if (WARN_ON_ONCE(len > MAX_ARG_STRLEN - 1)) {
> 
>   send_sig(SIGKILL, current, 0);
> 
>   return -1;
> 
>   }
> 
> -- 
> 
> 1.9.1

> --
> Linux-audit mailing list
> Linux-audit@...hat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives