linux-kernel - Re: [PATCH] Staging: android: ion: Fix Style Issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150714093637.GA15958@Morat.xayto.local>
Date:	Tue, 14 Jul 2015 09:36:37 +0000
From:	Craig Inches <craig.inches@...to.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Craig <craig.inches@...to.net>, gregkh@...uxfoundation.org,
	arve@...roid.com, riandrews@...roid.com, mitchelh@...eaurora.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: ion: Fix Style Issue

On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote:
> On Mon, 2015-07-13 at 17:29 +0000, Craig wrote:
> > Modified style issue in ion.c. Missing empty line after a definition
> > 
> > Signed-off-by: Craig <craig.inches@...to.net>
> > ---
> >  drivers/staging/android/ion/ion.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> > index 6f48112..e44f5e6 100644
> > --- a/drivers/staging/android/ion/ion.c
> > +++ b/drivers/staging/android/ion/ion.c
> > @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> >  	struct ion_buffer *buffer;
> >  	struct dma_buf *dmabuf;
> >  	bool valid_handle;
> > +
> >  	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
> >  
> >  	mutex_lock(&client->lock);
> 
> checkpatch false positive.
Thanks for the feed back.

> Fixed in checkpatch by
> https://lkml.org/lkml/2015/7/1/383
and the reference to the fix.

Cheers,
Craig 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/