linux-kernel - Re: [PATCH 09/10] blkcg: move io_service_bytes and io_serviced stats into blkcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150714160908.GG10792@redhat.com>
Date:	Tue, 14 Jul 2015 12:09:08 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org, kernel-team@...com,
	avanzini.arianna@...il.com
Subject: Re: [PATCH 09/10] blkcg: move io_service_bytes and io_serviced stats
 into blkcg_gq

On Sun, Jul 12, 2015 at 02:00:42PM -0400, Tejun Heo wrote:
> Currently, both cfq-iosched and blk-throttle keep track of
> io_service_bytes and io_serviced stats.  While keeping track of them
> separately may be useful during development, it doesn't make much
> sense otherwise.  Also, blk-throttle was counting bio's as IOs while
> cfq-iosched request's, which is more confusing than informative.

Hi Tejun,

So now blkio.io_serviced will switch to accounting number of bios
instead of number of requests? I feel given other stats, things
are still confusing as other stats will similar name give stats
about requests and not bios.

IMHO, for a policy, either all the stats should be in bio or in terms
of requests. Having a mix of these is even more confusing.

For example, IIUC, now blkio.io_serviced will keep count in terms of
bios while blkio.io_queued will keep count in terms of number of
requests.

If we are keeping common stats at block layer (instead of per policy),
I am wondering if it will make sense to reflect that in new cgroup
files which are common to all policies in that cgroup, instead of being per
policy. And deperecate respective per policy stat files over a period of time.

This will have 3 pros.

- We will not have to deal with any user complaints of suddenly switching
  accounting from request to bio for two cfq knobs.

- It will be less confusion otherwise some CFQ knobs will be bio based
  while others will be request based.

- It will also get rid of confusion about switching elevators and stat
  collection etc. 

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/