linux-kernel - Re: [PATCH v2 4/8] MIPS: Remove "weak" from get_c0_perfcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL1qeaFvRAqJ7pHkP-ELFV7b7BzxgnT=nUjv9Ae2WnSLBzw64g@mail.gmail.com>
Date:	Tue, 14 Jul 2015 10:13:26 -0700
From:	Andrew Bresticker <abrestic@...omium.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	James Hogan <james.hogan@...tec.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/8] MIPS: Remove "weak" from get_c0_perfcount_int() declaration

Hi Bjorn,

On Tue, Jul 14, 2015 at 9:46 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> Weak header file declarations are error-prone because they make every
> definition weak, and the linker chooses one based on link order (see
> 10629d711ed7 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node
> decl")).
>
> get_c0_perfcount_int() is defined in several files.  Every definition is
> weak, so I assume Kconfig prevents two or more from being included.  The
> callers contain identical default code used when get_c0_perfcount_int()
> isn't defined at all.
>
> Add a weak get_c0_perfcount_int() definition with the default code and
> remove the weak annotation from the declaration.
>
> Then the platform implementations will be strong and will override the weak
> default.  If multiple platforms are ever configured in, we'll get a link
> error instead of calling a random platform's implementation.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> CC: Andrew Bresticker <abrestic@...omium.org>

Reviewed-by: Andrew Bresticker <abrestic@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/