linux-kernel - Re: [PATCH 0/2] Configurable max discard size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55A556A2.8040605@fb.com>
Date:	Tue, 14 Jul 2015 12:36:18 -0600
From:	Jens Axboe <axboe@...com>
To:	Christoph Hellwig <hch@....de>
CC:	<linux-kernel@...r.kernel.org>, <snitzer@...hat.com>
Subject: Re: [PATCH 0/2] Configurable max discard size

On 07/14/2015 11:53 AM, Christoph Hellwig wrote:
> On Tue, Jul 14, 2015 at 10:04:12AM -0600, Jens Axboe wrote:
>> Based on experimentation with two different vendors, 64MB would be a good
>> default. Question is how best to set that. At least with the current patch,
>> untouched, 'discard_max_bytes' will still show the hw max value. If I
>> default it to 64MB, we'd lose that information until people started bumping
>> it up in size. Maybe that's not such a big deal, however.
>
> Just expose the max value as another read-only sysfs value?

Sure, just didn't want to clutter it with Yet Another sysfs file. But we 
could add 'discard_max_hw_bytes', that would be the obvious choice.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/