linux-kernel - Re: [PATCH 3/4] arm64: Add Broadcom's North Star 2 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A57AF2.8000903@broadcom.com>
Date:	Tue, 14 Jul 2015 14:11:14 -0700
From:	Ray Jui <rjui@...adcom.com>
To:	Catalin Marinas <catalin.marinas@....com>
CC:	Will Deacon <will.deacon@....com>, Arnd Bergmann <arnd@...db.de>,
	"Bjorn Helgaas" <bhelgaas@...gle.com>,
	Hauke Mehrtens <hauke@...ke-m.de>, <linux-pci@...r.kernel.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/4] arm64: Add Broadcom's North Star 2 support



On 7/14/2015 2:14 AM, Catalin Marinas wrote:
> On Mon, Jul 13, 2015 at 06:39:14PM -0700, Ray Jui wrote:
>> This patch adds support to Broadcom's North Star 2 SoC in the arm64
>> Kconfig and defconfig files
>>
>> Signed-off-by: Ray Jui <rjui@...adcom.com>
>> Reviewed-by: Scott Branden <sbranden@...adcom.com>
>> ---
>>  arch/arm64/Kconfig           |   12 ++++++++++++
>>  arch/arm64/configs/defconfig |    2 ++
>>  2 files changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 318175f..6c5c279 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -162,6 +162,18 @@ source "kernel/Kconfig.freezer"
>>  
>>  menu "Platform selection"
>>  
>> +config ARCH_BCM_IPROC
>> +	bool
>> +	help
>> +	  This enables support for Broadcom iProc based SoCs
>> +
>> +config ARCH_BCM_NS2
>> +	bool "Broadcom North Start 2 (BCM5871X)"
>> +	select ARCH_BCM_IPROC
>> +	help
>> +	  This enables support for Broadcom NS2 (BCM5871X). NS2 is in
>> +	  the iProc family of SoCs based on the ARMv8 architecture
> 
> Do you really need the second config option? Just leave the one covering
> the family as we do for most of the other family SoCs on arm64 (apart
> from ARCH_TEGRA_123_SOC which I plan to remove and use ARCH_TEGRA
> instead).
> 

ARCH_BCM_NS2 helps in cases where a NS2 specific driver may just default
to ARCH_BCM_NS2 in its Kconfig, so those NS2 drivers got turned on
whenever ARCH_BCM_NS2 is turned on.

If the plan is to allow only one ARCH flag per family of SoCs for ARMv8,
I can go ahead and remove ARCH_BCM_NS2.

Thanks,

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/