linux-kernel - Re: [PATCH] ARM: pxa: Use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lheijugs.fsf@belgarion.home>
Date:	Tue, 14 Jul 2015 23:32:51 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Vaishali Thakkar <vthakkar1994@...il.com>
Cc:	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Julia Lawall <julia.lawall@...6.fr>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: pxa: Use setup_timer

Vaishali Thakkar <vthakkar1994@...il.com> writes:

> Use the timer API function setup_timer instead of structure field
> assignments to initialize a timer.
>
> A simplified version of the Coccinelle semantic patch that performs
> this transformation is as follows:
>
> @change@
> expression e1, e2, a;
> @@
>
> -init_timer(&e1);
> +setup_timer(&e1, a, 0UL);
> ... when != a = e2
> -e1.function = a;
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
Looks good to me.
I'll queue that in pxa/for-next, thanks.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/