linux-kernel - Re: [PATCH 35/42] x86, boot, PCI: Convert SETUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150714223537.GQ24416@google.com>
Date:	Tue, 14 Jul 2015 17:35:37 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Kees Cook <keescook@...omium.org>,
	"H. Peter Anvin" <hpa@...or.com>, Baoquan He <bhe@...hat.com>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 35/42] x86, boot, PCI: Convert SETUP_PCI data to list

On Tue, Jul 07, 2015 at 01:20:21PM -0700, Yinghai Lu wrote:
> So we could avoid ioremap every time later.

The changelog (not just the subject) should say what you're doing.

> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
> index 16ace12..32d4f21 100644
> --- a/arch/x86/pci/common.c
> +++ b/arch/x86/pci/common.c

> +struct firmware_setup_pci_entry {
> +	struct list_head list;
> +	uint16_t vendor;
> +	uint16_t devid;
> +	uint64_t pcilen;

Is there a reason to use uint16_t and uint64_t instead of u16 and u64?

> +	unsigned long segment;
> +	unsigned long bus;
> +	unsigned long device;
> +	unsigned long function;
> +	phys_addr_t romdata;
> +};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/