linux-kernel - Re: [patch] checkpatch: Fixes: tag lines are allowed to be long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1436933517.16262.13.camel@perches.com>
Date:	Tue, 14 Jul 2015 21:11:57 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, Jes.Sorensen@...hat.com,
	sparmaintainer@...sys.com, driverdev-devel@...uxdriverproject.org,
	Tim Sell <Timothy.Sell@...sys.com>
Subject: Re: [patch] checkpatch: Fixes: tag lines are allowed to be long

On Tue, 2015-07-14 at 14:07 +0300, Dan Carpenter wrote:
> A lot of the Fixes: tags go over the 75 character limit and that's ok.
> 
> Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> The other common cause of false positives it Oops output but I don't
> have an idea how to filter for that.
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 90e1edc..537973b 100755[0-9a-f
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2310,7 +2310,7 @@ sub process {
>  
>  # Check for line lengths > 75 in commit log, warn once
>  		if ($in_commit_log && !$commit_log_long_line &&
> -		    length($line) > 75) {
> +		    length($line) > 75 && !($line =~ /^Fixes:/)) {
>  			WARN("COMMIT_LOG_LONG_LINE",
>  			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
>  			$commit_log_long_line = 1;

Maybe some combination of:

^\s*> 
^.*\[\s*timestamp\s*\]
^\s*\[\<0-9a-f\>\]
oops:
BUG: Unable to 
Unable to

Followed by any blank line to reset

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/