linux-kernel - Re: [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150715045720.GB17865@sudip-PC>
Date:	Wed, 15 Jul 2015 10:27:20 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from
 rtllib_stats

On Tue, Jul 14, 2015 at 10:04:08PM +0200, Mateusz Kulikowski wrote:
> None of them are used in the driver.
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
> ---
>  drivers/staging/rtl8192e/rtllib.h | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 8ba92ed..dc0653a 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -691,27 +691,8 @@ struct rtllib_frag_entry {
>  };
>  
>  struct rtllib_stats {
> -	unsigned int tx_unicast_frames;
> -	unsigned int tx_multicast_frames;
> -	unsigned int tx_fragments;
> -	unsigned int tx_unicast_octets;
> -	unsigned int tx_multicast_octets;
> -	unsigned int tx_deferred_transmissions;
> -	unsigned int tx_single_retry_frames;
> -	unsigned int tx_multiple_retry_frames;
> -	unsigned int tx_retry_limit_exceeded;
>  	unsigned int tx_discards;
> -	unsigned int rx_unicast_frames;
> -	unsigned int rx_multicast_frames;
> -	unsigned int rx_fragments;
> -	unsigned int rx_unicast_octets;
> -	unsigned int rx_multicast_octets;
> -	unsigned int rx_fcs_errors;
> -	unsigned int rx_discards_no_buffer;
> -	unsigned int tx_discards_wrong_sa;
>  	unsigned int rx_discards_undecryptable;
Dan had commented before that tx_discards and rx_discards_undecryptable
are also not used. Their only uses are:
 ieee->ieee_stats.rx_discards_undecryptable++ and
 ieee->ieee_stats.tx_discards++

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/