lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jul 2015 08:34:02 +0200 From: Jakub Sitnicki <jsitnicki@...il.com> To: Mateusz Kulikowski <mateusz.kulikowski@...il.com> Cc: gregkh@...uxfoundation.org, dan.carpenter@...cle.com, sudipm.mukherjee@...il.com, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 04/23] staging: rtl8192e: Remove unused enums On Tue, Jul 14, 2015 at 10:04 PM CEST, Mateusz Kulikowski <mateusz.kulikowski@...il.com> wrote: > Remove ack_policy enum and some unused RTL_DEBUG enums. > > Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com> > --- [snip] > diff --git a/drivers/staging/rtl8192e/rtllib_debug.h b/drivers/staging/rtl8192e/rtllib_debug.h > index 42e88d6..2f47a7c 100644 > --- a/drivers/staging/rtl8192e/rtllib_debug.h > +++ b/drivers/staging/rtl8192e/rtllib_debug.h > @@ -40,10 +40,7 @@ enum RTL_DEBUG { > COMP_DBG = (1 << 1), > COMP_INIT = (1 << 2), > COMP_RECV = (1 << 3), > - COMP_SEND = (1 << 4), > - COMP_CMD = (1 << 5), > COMP_POWER = (1 << 6), > - COMP_EPROM = (1 << 7), > COMP_SWBW = (1 << 8), > COMP_SEC = (1 << 9), > COMP_LPS = (1 << 10), > @@ -58,15 +55,12 @@ enum RTL_DEBUG { > COMP_CH = (1 << 19), > COMP_RF = (1 << 20), > COMP_FIRMWARE = (1 << 21), > - COMP_HT = (1 << 22), > COMP_RESET = (1 << 23), > COMP_CMDPKT = (1 << 24), > COMP_SCAN = (1 << 25), > COMP_PS = (1 << 26), > COMP_DOWN = (1 << 27), > COMP_INTR = (1 << 28), > - COMP_LED = (1 << 29), > - COMP_MLME = (1 << 30), > COMP_ERR = (1 << 31) > }; Is it possible that this change will make future readers wonder why there are holes in the enum values, and hence hurts readability? Cheers, Jakub -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists