linux-kernel - Re: [PATCH 3/6] security: Introduce security

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1507151218060.18576@nanos>
Date:	Wed, 15 Jul 2015 12:24:09 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Baolin Wang <baolin.wang@...aro.org>
cc:	serge.hallyn@...onical.com, arnd@...db.de, john.stultz@...aro.org,
	linux-kernel@...r.kernel.org, james.l.morris@...cle.com,
	serge@...lyn.com, paul@...l-moore.com, john.johansen@...onical.com,
	sds@...ho.nsa.gov, casey@...aufler-ca.com,
	penguin-kernel@...ove.SAKURA.ne.jp, neilb@...e.de,
	edumazet@...gle.com, jlayton@...marydata.com,
	linux-security-module@...r.kernel.org, y2038@...ts.linaro.org
Subject: Re: [PATCH 3/6] security: Introduce security_settime64()

On Wed, 15 Jul 2015, Baolin Wang wrote:

> security_settime() returns a timespec, which is not year 2038 safe

It returns int, which is year 2038 safe on all systems. Copy and paste
is great, right?

> -int security_settime(const struct timespec *ts, const struct timezone *tz);
> +int security_settime64(const struct timespec64 *ts, const struct timezone *tz);
> +static inline int security_settime(const struct timespec *ts, const struct timezone *tz)
> +{
> +	struct timespec64 ts64 = timespec_to_timespec64(*ts);
> +
> +	return security_settime64(&ts64, tz);
> +}

What's the point of this inline? Explanation is missing in
changelog.

Also this wants follow up patches which fix the call sites and remove
that inline helper again.

> -int cap_settime(const struct timespec *ts, const struct timezone *tz)
> +int cap_settime(const struct timespec64 *ts, const struct timezone *tz)

Changelog is missing that none of the existing hooks is using the ts
argument and therefor the patch is not doing any functional changes.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/