linux-kernel - Re: [PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xa1t4ml5fx13.fsf@mina86.com>
Date:	Wed, 15 Jul 2015 14:03:20 +0200
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Joonsoo Kim <js1304@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Sasha Levin <sasha.levin@...cle.com>,
	Stefan Strogin <stefan.strogin@...il.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface

On Wed, Jul 15 2015, Joonsoo Kim wrote:
> CMA has alloc/free interface for debugging. It is intended that alloc/free
> occurs in specific CMA region, but, currently, alloc/free interface is
> on root dir due to the bug so we can't select CMA region where alloc/free
> happens.
>
> This patch fixes this problem by making alloc/free interface per
> CMA region.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
>  mm/cma_debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/cma_debug.c b/mm/cma_debug.c
> index 7621ee3..22190a7 100644
> --- a/mm/cma_debug.c
> +++ b/mm/cma_debug.c
> @@ -170,10 +170,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
>  
>  	tmp = debugfs_create_dir(name, cma_debugfs_root);
>  
> -	debugfs_create_file("alloc", S_IWUSR, cma_debugfs_root, cma,
> +	debugfs_create_file("alloc", S_IWUSR, tmp, cma,
>  				&cma_alloc_fops);
>  
> -	debugfs_create_file("free", S_IWUSR, cma_debugfs_root, cma,
> +	debugfs_create_file("free", S_IWUSR, tmp, cma,
>  				&cma_free_fops);
>  
>  	debugfs_create_file("base_pfn", S_IRUGO, tmp,
> -- 
> 1.9.1
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@...gle.com>--<xmpp:mina86@...ber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/