linux-kernel - Re: KDBUS breaks 'make installmandocs'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4QgzTFijvkfqa-sEYfVktJLEA3+oFh6Sm8NekLie6B9Ww@mail.gmail.com>
Date:	Wed, 15 Jul 2015 16:19:28 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Jim Davis <jim.epost@...il.com>
Cc:	Ulf Magnusson <ulfalizer.lkml@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Linux API <linux-api@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>
Subject: Re: KDBUS breaks 'make installmandocs'

Hi

On Tue, Jul 14, 2015 at 8:24 PM, Jim Davis <jim.epost@...il.com> wrote:
> On Mon, Jul 13, 2015 at 7:00 PM, Ulf Magnusson <ulfalizer.lkml@...il.com> wrote:
>> On Mon, Jul 13, 2015 at 05:39:25PM -0700, Greg KH wrote:
>>> On Sun, Jul 12, 2015 at 08:08:46PM +0200, Ulf Magnusson wrote:
>>> > Hello,
>>> >
>>> > Tested with next-20150709.
>>> >
>>> > Documentation/kdbus/Makefile lacks an 'installmandocs' target, causing
>>> > problems for
>>> >
>>> > %docs: scripts_basic FORCE
>>> >     $(Q)$(MAKE) $(build)=scripts build_docproc
>>> >     $(Q)$(MAKE) $(build)=Documentation/DocBook $@
>>> >     $(Q)$(MAKE) $(build)=Documentation/kdbus $@
>>> >
>>> > from the top-level Makefile. It still works, but no KDBUS-related man
>>> > pages are installed, and the final error isn't reassuring.
>>>
>>> What's the final error?
>>>
>>
>> $ sudo make installmandocs
>>   GEN     Documentation/DocBook//v4l2.xml
>> find Documentation/DocBook/man -name '*.9' | xargs gzip -f
>> mkdir -p /usr/local/man/man9/
>> install Documentation/DocBook/man/*.9.gz /usr/local/man/man9/
>> make[1]: *** No rule to make target 'installmandocs'.  Stop.
>> Makefile:1359: recipe for target 'installmandocs' failed
>> make: *** [installmandocs] Error 2
>>
>>
>> The "*** No rule to make target 'installmandocs'. Stop." error is
>> generated for Documentation/kdbus/Makefile. The other man pages still
>> install fine.
>
> There's a similar problem with 'make cleandocs'.  Adding noop rules
> for installdocs and cleandocs to Documentation/kdbus/Makefile at least
> gets rid of the error messages.

So the Docbook targets support much more %docs targets than just
cleandocs and installdocs. I don't think it's reasonable to guarantee
that all those targets are supported for all documentation subdirs.
Hence, I'd propose the attached patch. This should at least make sure
the targets won't fail.

But I think we should look into cleandocs and installmandocs. I'll
have a look into that later. This patch should just fix all the other
targets right now.

Thanks
David


diff --git a/Documentation/kdbus/Makefile b/Documentation/kdbus/Makefile
index af87641..8caffe5 100644
--- a/Documentation/kdbus/Makefile
+++ b/Documentation/kdbus/Makefile
@@ -38,3 +38,7 @@ mandocs: $(MANFILES)
 htmldocs: $(HTMLFILES)

 clean-files := $(MANFILES) $(HTMLFILES)
+
+# we don't support other %docs targets right now
+%docs:
+       @true
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/