linux-kernel - Re: [PATCH nf-next] netfilter: nf_ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Jul 2015 18:45:40 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	linux-api@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming
 support

On Tue, Jul 14, 2015 at 06:28:50PM +0200, Michal Kubecek wrote:
> On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote:
> > On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote:
> > > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = {
> > >  		.mode		= 0644,
> > >  		.proc_handler	= proc_dointvec_jiffies,
> > >  	},
> > > +	{
> > > +		.procname	= "nf_conntrack_sctp_timeout_heartbeat_sent",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > > +	{
> > > +		.procname	= "nf_conntrack_sctp_timeout_heartbeat_acked",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > >  	{ }
> > >  };
> > >  
> > > @@ -705,6 +755,18 @@ static struct ctl_table sctp_compat_sysctl_table[] = {
> > >  		.mode		= 0644,
> > >  		.proc_handler	= proc_dointvec_jiffies,
> > >  	},
> > > +	{
> > > +		.procname	= "ip_conntrack_sctp_timeout_heartbeat_sent",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > > +	{
> > > +		.procname	= "ip_conntrack_sctp_timeout_heartbeat_acked",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > >  	{ }
> > 
> > I don't see the nla_policy updates for the netlink cttimeout
> > interface.
> 
> I didn't realize those were needed. It means adding two entries to
> sctp_timeout_nla_policy and two values to enum ctattr_timeout_sctp?

Exactly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/