linux-kernel - Re: [PATCH 09/10] blkcg: move io_service_bytes and io_serviced stats into blkcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Jul 2015 12:53:26 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org, kernel-team@...com,
	avanzini.arianna@...il.com
Subject: Re: [PATCH 09/10] blkcg: move io_service_bytes and io_serviced stats
 into blkcg_gq

Hello, Vivek.

On Wed, Jul 15, 2015 at 12:29:52PM -0400, Vivek Goyal wrote:
> Ok. I am personally little apprehensive of changing the meaning of 
> current stat, but I can live with it.

Sure, if there are use cases which actually get impacted by this,
reverting the original stats shouldn't be difficult.  I don't think
it's likely to matter tho.  I mean, we even get sync / async
distinction completely wrong in these stats.  We're really pumping out
garbage.

> Can you please also update the blkio-controller.txt to reflect these
> changes. I think following sections would require updation.
> 
> blkio.throttle.io_serviced
> blkio.throttle.io_service_bytes
> 
> And we could mention in blkio.io_serviced that accounting is terms of
> numeber of bios.

Sure thing.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/