linux-kernel - [PATCH 7/7] smack: Don't use security labels for user namespace mounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1436989569-69582-8-git-send-email-seth.forshee@canonical.com>
Date:	Wed, 15 Jul 2015 14:46:08 -0500
From:	Seth Forshee <seth.forshee@...onical.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Casey Schaufler <casey@...aufler-ca.com>
Cc:	Serge Hallyn <serge.hallyn@...onical.com>,
	Andy Lutomirski <luto@...capital.net>,
	Seth Forshee <seth.forshee@...onical.com>,
	linux-fsdevel@...r.kernel.org,
	linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov,
	linux-kernel@...r.kernel.org,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>
Subject: [PATCH 7/7] smack: Don't use security labels for user namespace mounts

Avoid use of untrusted security labels when s_user_ns !=
init_user_ns:
 - smk_fetch: refuse to read labels from disk
 - smack_inode_init_security: return -ENOTSUPP
 - smack_d_instantiate: don't use security xattrs from disk

Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
---
 security/smack/smack_lsm.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index a143328f75eb..6a849da94f47 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -255,6 +255,9 @@ static struct smack_known *smk_fetch(const char *name, struct inode *ip,
 	char *buffer;
 	struct smack_known *skp = NULL;
 
+	if (ip->i_sb->s_user_ns != &init_user_ns)
+		return NULL;
+
 	if (ip->i_op->getxattr == NULL)
 		return ERR_PTR(-EOPNOTSUPP);
 
@@ -833,6 +836,9 @@ static int smack_inode_init_security(struct inode *inode, struct inode *dir,
 	struct smack_known *dsp = smk_of_inode(dir);
 	int may;
 
+	if (inode->i_sb->s_user_ns != &init_user_ns)
+		return -ENOTSUPP;
+
 	if (name)
 		*name = XATTR_SMACK_SUFFIX;
 
@@ -3176,11 +3182,13 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)
 		}
 		/*
 		 * No xattr support means, alas, no SMACK label.
-		 * Use the aforeapplied default.
+		 * Use the aforeapplied default. Also don't use
+		 * xattrs from userns mounts.
 		 * It would be curious if the label of the task
 		 * does not match that assigned.
 		 */
-		if (inode->i_op->getxattr == NULL)
+		if (inode->i_sb->s_user_ns != &init_user_ns ||
+		    inode->i_op->getxattr == NULL)
 			break;
 		/*
 		 * Get the dentry for xattr.
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/