linux-kernel - Re: [PATCH 1/1] mem-hotplug: Handle node hole when initializing numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150715212008.GK15934@mtj.duckdns.org>
Date:	Wed, 15 Jul 2015 17:20:08 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Tang Chen <tangchen@...fujitsu.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	akpm@...ux-foundation.org, dyoung@...hat.com,
	isimatu.yasuaki@...fujitsu.com, yasu.isimatu@...il.com,
	lcapitulino@...hat.com, qiuxishi@...wei.com, will.deacon@....com,
	tony.luck@...el.com, vladimir.murzin@....com, fabf@...net.be,
	kuleshovmail@...il.com, bhe@...hat.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/1] mem-hotplug: Handle node hole when initializing
 numa_meminfo.

On Wed, Jul 01, 2015 at 11:16:54AM +0800, Tang Chen wrote:
...
> -		/* and there's no empty block */
> -		if (bi->start >= bi->end)
> +		/* and there's no empty or non-exist block */
> +		if (bi->start >= bi->end ||
> +		    memblock_overlaps_region(&memblock.memory,
> +			bi->start, bi->end - bi->start) == -1)

Ugh.... can you please change memblock_overlaps_region() to return
bool instead?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/