linux-kernel - Re: [PATCH v9 07/22] tracing: Add lock-free tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150716174946.GH12596@twins.programming.kicks-ass.net>
Date:	Thu, 16 Jul 2015 19:49:46 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc:	rostedt@...dmis.org, daniel.wagner@...-carit.de,
	masami.hiramatsu.pt@...achi.com, namhyung@...nel.org,
	josh@...htriplett.org, andi@...stfloor.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map

On Thu, Jul 16, 2015 at 12:22:40PM -0500, Tom Zanussi wrote:
> +	for (i = 0; i < elt->map->n_fields; i++) {
> +		atomic64_set(&dup_elt->fields[i].sum,
> +			     atomic64_read(&elt->fields[i].sum));
> +		dup_elt->fields[i].cmp_fn = elt->fields[i].cmp_fn;
> +	}
> +
> +	return dup_elt;
> +}

So there is a lot of atomic64_{set,read}() in this patch set, what kind
of magic properties do you assume they have?

Note that atomic*_{set,read}() are weaker than {WRITE,READ}_ONCE(), so
if you're assuming they do that, you're mistaken -- although it is on a
TODO list someplace to go fix that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/