linux-kernel - RE: [PATCH] infiniband:cxgb4:Make the function rdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 13:40:41 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Nicholas Krause'" <xerofoify@...il.com>, <swise@...lsio.com>
Cc:	<dledford@...hat.com>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool

Is this change really worth the effort?


> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Thursday, July 16, 2015 1:34 PM
> To: swise@...lsio.com
> Cc: dledford@...hat.com; sean.hefty@...el.com; hal.rosenstock@...il.com; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool
> 
> This makes the function rdma_supported have a return type of bool
> due to this particular function's return statement always returning
> either one or zero as its return value.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/infiniband/hw/cxgb4/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 1a29739..285f6606 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -912,7 +912,7 @@ static void c4iw_remove(struct uld_ctx *ctx)
>  	c4iw_dealloc(ctx);
>  }
> 
> -static int rdma_supported(const struct cxgb4_lld_info *infop)
> +static bool rdma_supported(const struct cxgb4_lld_info *infop)
>  {
>  	return infop->vr->stag.size > 0 && infop->vr->pbl.size > 0 &&
>  	       infop->vr->rq.size > 0 && infop->vr->qp.size > 0 &&
> --
> 2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/