linux-kernel - Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1437073957.2495.32.camel@perches.com>
Date:	Thu, 16 Jul 2015 12:12:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Guillaume Bienkowski <guitreize@...il.com>, luca@...aceresoli.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings

On Thu, 2015-07-16 at 10:11 -0700, Greg KH wrote:
> On Thu, Jul 16, 2015 at 09:41:36AM +0200, Guillaume Bienkowski wrote:
> > Fix spaces before comma and indentation.
> 
> That's two different things, so this should be two different patches
> please.

I think it'd be better to do all the whitespace changes
in a single go:

$ git ls-files drivers/staging/rtl8188eu | \
  xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space --strict

and submit the git diff with "whitespace style changes"
after verifying that objdiff shows no changes.

 64 files changed, 1240 insertions(+), 1240 deletions(-)

It's ~330KB patch though.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/