linux-kernel - Re: [PATCH] Bluetooth: cmtp: Do not use list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1507162251580.2797@hadrien>
Date:	Thu, 16 Jul 2015 22:52:24 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:	marcel@...tmann.org, gustavo@...ovan.org, johan.hedberg@...il.com,
	davem@...emloft.net, linux-bluetooth@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: cmtp: Do not use list_for_each_safe when not
 needed

On Thu, 16 Jul 2015, Christophe JAILLET wrote:

> There is no need to use the safe version of list_for_each here.
Why not list_for_each_entry?  Maybe it's too much of a change to make at
once...

julia

>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  net/bluetooth/cmtp/capi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/bluetooth/cmtp/capi.c b/net/bluetooth/cmtp/capi.c
> index b0c6c6a..4c5e3e0 100644
> --- a/net/bluetooth/cmtp/capi.c
> +++ b/net/bluetooth/cmtp/capi.c
> @@ -100,9 +100,9 @@ static void cmtp_application_del(struct cmtp_session *session, struct cmtp_appli
>  static struct cmtp_application *cmtp_application_get(struct cmtp_session *session, int pattern, __u16 value)
>  {
>  	struct cmtp_application *app;
> -	struct list_head *p, *n;
> +	struct list_head *p;
>
> -	list_for_each_safe(p, n, &session->applications) {
> +	list_for_each(p, &session->applications) {
>  		app = list_entry(p, struct cmtp_application, list);
>  		switch (pattern) {
>  		case CMTP_MSGNUM:
> @@ -511,13 +511,13 @@ static int cmtp_proc_show(struct seq_file *m, void *v)
>  	struct capi_ctr *ctrl = m->private;
>  	struct cmtp_session *session = ctrl->driverdata;
>  	struct cmtp_application *app;
> -	struct list_head *p, *n;
> +	struct list_head *p;
>
>  	seq_printf(m, "%s\n\n", cmtp_procinfo(ctrl));
>  	seq_printf(m, "addr %s\n", session->name);
>  	seq_printf(m, "ctrl %d\n", session->num);
>
> -	list_for_each_safe(p, n, &session->applications) {
> +	list_for_each(p,  &session->applications) {
>  		app = list_entry(p, struct cmtp_application, list);
>  		seq_printf(m, "appl %d -> %d\n", app->appl, app->mapping);
>  	}
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/