linux-kernel - Re: [PATCH] ibmvscsi:Remove no longer required comments about return values in the file ibmvfc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55A81D21.6030006@linux.vnet.ibm.com>
Date:	Thu, 16 Jul 2015 14:07:45 -0700
From:	Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
To:	Nicholas Krause <xerofoify@...il.com>
CC:	JBottomley@...n.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ibmvscsi:Remove no longer required comments about return
 values in the file ibmvfc.c

On 07/09/2015 10:41 AM, Nicholas Krause wrote:
> This removes the no longer require comments about the return values
> for the functions ibmvfc_init_host and  ibmvfc_reinit_host due to
> these functions being declared to have a return type of void thus
> making this comments invalid.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

Some grammar nit picking. Aside from a couple spelling errors the
wording is a little difficult. Refer to Documentation/SubmittingPatches
section 2. In particular it suggests using the imperative mood.
Something like this would work better:

"Remove comments about return values from ibmvfc_init_host() and
ibmvfc_reinit_host() as they are both declared to have return type void."

Otherwise,

Acked-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>

> ---
>  drivers/scsi/ibmvscsi/ibmvfc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 057d277..c6582db 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -528,8 +528,6 @@ static void ibmvfc_set_host_action(struct ibmvfc_host *vhost,
>   * ibmvfc_reinit_host - Re-start host initialization (no NPIV Login)
>   * @vhost:		ibmvfc host struct
>   *
> - * Return value:
> - *	nothing
>   **/
>  static void ibmvfc_reinit_host(struct ibmvfc_host *vhost)
>  {
> @@ -570,8 +568,6 @@ static void ibmvfc_link_down(struct ibmvfc_host *vhost,
>   * ibmvfc_init_host - Start host initialization
>   * @vhost:		ibmvfc host struct
>   *
> - * Return value:
> - *	nothing
>   **/
>  static void ibmvfc_init_host(struct ibmvfc_host *vhost)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/