linux-kernel - Re: [PATCH] ftrace: add tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150716174554.500ae238@gandalf.local.home>
Date:	Thu, 16 Jul 2015 17:45:54 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Umesh Tiwari <umesh.t@...sung.com>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org,
	gupta.namit@...sung.com, pankaj.m@...sung.com,
	Himanshu Maithani <himanshu.m@...sung.com>
Subject: Re: [PATCH] ftrace: add tracing_thresh to function profile

On Mon, 22 Jun 2015 16:58:08 +0530
Umesh Tiwari <umesh.t@...sung.com> wrote:

> From: Himanshu Maithani <himanshu.m@...sung.com>
> 
> This patch extends tracing_thresh functionality to function profile tracer.
> If tracing_thresh is set, print those entries only,
> whose average is > tracing thresh.
> 
> Signed-off-by: Umesh Tiwari <umesh.t@...sung.com>
> ---
>  kernel/trace/ftrace.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 4f22802..7a48a67 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -600,13 +600,19 @@ static int function_stat_show(struct seq_file *m, void *v)
>  		goto out;
>  	}
>  
> +	/* moved above to avoid printing values < thresh */

This comment isn't needed. People looking at this code wont know that
it use to be below.

-- Steve

> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +	avg = rec->time;
> +	do_div(avg, rec->counter);
> +	if (tracing_thresh && (avg < tracing_thresh))
> +		goto out;
> +#endif
> +
>  	kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
>  	seq_printf(m, "  %-30.30s  %10lu", str, rec->counter);
>  
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>  	seq_puts(m, "    ");
> -	avg = rec->time;
> -	do_div(avg, rec->counter);
>  
>  	/* Sample standard deviation (s^2) */
>  	if (rec->counter <= 1)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/