linux-kernel - Re: [PATCH 2/2] cpufreq: Properly handle errors from cpufreq_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3304290.JRKWihrc9M@vostro.rjw.lan>
Date:	Fri, 17 Jul 2015 01:07:15 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	"Jon Medhurst (Tixy)" <tixy@...aro.org>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] cpufreq: Properly handle errors from cpufreq_init_policy()

On Thursday, July 16, 2015 10:16:14 AM Jon Medhurst wrote:
> On Thu, 2015-07-16 at 02:32 +0200, Rafael J. Wysocki wrote:
> > On Wednesday, July 08, 2015 04:50:23 PM Viresh Kumar wrote:
> > > On 08-07-15, 12:17, Jon Medhurst (Tixy) wrote:
> > > > I tried these patches without the earlier "cpufreq: Initialize the
> > > > governor again while restoring policy" patch.
> > > > 
> > > > The result is that the error when bringing a cpu online is with flagged
> > > > up with a kernel message:
> > > > 
> > > >   cpufreq: cpufreq_add_dev: Failed to initialize policy for cpu: 1 (-16)
> > > > 
> > > > and afterwards, the sysfs entries that I was poking and causing the
> > > > crash aren't present. So looks like this patch has done what we want,
> > > > and cleaned things up after an error. So...
> > > > 
> > > > Tested-by: Jon Medhurst <tixy@...aro.org>
> > > > 
> > > > Thanks for the prompt fix.
> > > 
> > > And thanks for your help in getting these tested :)
> > 
> > Both queued up for 4.3, thanks!
> 
> The crash I was getting was a regression caused by changes that went
> into 4.2-rc1.
> 
> Indeed, the first patch from Viresh is marked:
> 
> Fixes: 18bf3a124ef8 ("cpufreq: Mark policy->governor = NULL for inactive policies")
> For 4.2-rc
> 
> And I am having to carry that first patch to keep two ARM big.LITTLE
> platforms working.

That one is going into 4.2-rc, I'm about to send a pull request with it.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/