[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.10.1507151727320.9230@chino.kir.corp.google.com>
Date: Wed, 15 Jul 2015 17:27:43 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
cc: linux-mm@...ck.org, Christoph Lameter <cl@...ux.com>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/slub: fix slab double-free in case of duplicate
sysfs filename
On Tue, 14 Jul 2015, Konstantin Khlebnikov wrote:
> sysfs_slab_add() shouldn't call kobject_put at error path: this puts
> last reference of kmem-cache kobject and frees it. Kmem cache will be
> freed second time at error path in kmem_cache_create().
>
> For example this happens when slub debug was enabled in runtime and
> somebody creates new kmem cache:
>
> # echo 1 | tee /sys/kernel/slab/*/sanity_checks
> # modprobe configfs
>
> "configfs_dir_cache" cannot be merged because existing slab have debug and
> cannot create new slab because unique name ":t-0000096" already taken.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists