linux-kernel - Re: [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150715.211306.576715827080894506.davem@davemloft.net>
Date:	Wed, 15 Jul 2015 21:13:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	decui@...rosoft.com
Cc:	gregkh@...uxfoundation.org, stephen@...workplumber.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, olaf@...fle.de,
	apw@...onical.com, jasowang@...hat.com, kys@...rosoft.com
Subject: Re: [V2 1/7] Drivers: hv: vmbus: define the new offer type for
 Hyper-V socket (hvsock)

From: Dexuan Cui <decui@...rosoft.com>
Date: Tue, 14 Jul 2015 02:58:03 -0700

> A helper function is also added.
> 
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> ---
>  include/linux/hyperv.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index 30d3a1f..aa21814 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -236,6 +236,7 @@ struct vmbus_channel_offer {
>  #define VMBUS_CHANNEL_LOOPBACK_OFFER			0x100
>  #define VMBUS_CHANNEL_PARENT_OFFER			0x200
>  #define VMBUS_CHANNEL_REQUEST_MONITORED_NOTIFICATION	0x400
> +#define VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER		0x2000
>  
>  struct vmpacket_descriptor {
>  	u16 type;
> @@ -758,6 +759,12 @@ struct vmbus_channel {
>  	struct list_head percpu_list;
>  };
>  
> +static inline bool is_hvsock_channel(const struct vmbus_channel *c)
> +{
> +	return !!(c->offermsg.offer.chn_flags &
> +		VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER);
> +}
> +

This is not indented properly, plus it makes no sense to add a flag before
anyone even sets the flag.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/