linux-kernel - Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437033944.27428.11.camel@tiscali.nl>
Date:	Thu, 16 Jul 2015 10:05:44 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Xing Zheng <zhengxing@...k-chips.com>
Cc:	dgreid@...omium.org, dianders@...omium.org, heiko@...ech.de,
	sonnyrao@...omium.org, linux-rockchip@...ts.infradead.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090
 codec

On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote:
> --- /dev/null
> +++ b/sound/soc/rockchip/rockchip_max98090.c

> +#define DRV_NAME "rockchip-snd-max98090"

> +static const struct of_device_id rockchip_max98090_of_match[] = {
> +	{ .compatible = "rockchip,rockchip-audio-max98090", },
> +	{},
> +};
> +
> +static struct platform_driver snd_rk_mc_driver = {
> +	.probe = snd_rk_mc_probe,
> +	.remove = snd_rk_mc_remove,
> +	.driver = {
> +		.name = DRV_NAME,
> +		.owner = THIS_MODULE,
> +		.pm = &snd_soc_pm_ops,
> +		.of_match_table = rockchip_max98090_of_match,
> +	},
> +};
> +
> +module_platform_driver(snd_rk_mc_driver);

Nit: empty line here.

> +MODULE_AUTHOR("jianqun <jay.xu@...k-chips.com>");
> +MODULE_DESCRIPTION("Rockchip max98090 machine ASoC driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:" DRV_NAME);

This seems only useful if there's a corresponding struct
platform_device. Ie, a platform_device with a "rockchip-snd-max98090"
.name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090"
uevent when it's created. But I couldn't find where such a
platform_device is created.

Did I miss something? Or is there another way this alias is useful here?

> +MODULE_DEVICE_TABLE(of, rockchip_max98090_of_match);

The common pattern is to put MODULE_DEVICE_TABLE() directly after the
table it exports.

Likewise for 2/2 (except the empty line nit, that is).

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/