linux-kernel - Re: [PATCH 4/4] Input: tsc2005

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 11:14:58 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org,
	Michael Welling <mwelling@...cinc.com>,
	Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod

On Wed, Jul 15, 2015 at 05:25:32PM -0700, Dmitry Torokhov wrote:
> On Thu, Jul 16, 2015 at 12:09:41AM +0200, Sebastian Reichel wrote:
> > On Wed, Jul 15, 2015 at 02:34:04PM -0700, Dmitry Torokhov wrote:
> > > [...]
> > > >  	if (np) {
> > > > -		ts->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0);
> > > > -		if (ts->reset_gpio == -EPROBE_DEFER)
> > > > -			return ts->reset_gpio;
> > > > -		if (ts->reset_gpio < 0) {
> > > > +		ts->reset_gpio = devm_gpiod_get(&spi->dev, "reset",
> > > > +						GPIOD_OUT_HIGH);
> > > 
> > > I think we should treat the gpio as optional and try to get the
> > > descriptor event on non-OF boards.
> > 
> > As I wrote in the cover letter, I suggest to change this once the
> > Nokia N900 board code has been removed. At that point changing the
> > board code API is much easier, since it won't affect multiple trees.
> 
> I do not see why it has be wait for Nokia board code. Just make it
> devm_gpiod_get_optional() and call it unconditionally and fall back onto
> custom reset function (if one is supplied).

Right. I guess the same could be done for vio regulator. I will
add this change in the next version of the patchset.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)