linux-kernel - Re: [PATCH] ALSA: hda/realtek: Enable HP amp and mute LED on HP Folio 9480m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 12:26:40 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Keith Packard <keithp@...thp.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>,
	Kailang Yang <kailang@...ltek.com>,
	Hui Wang <hui.wang@...onical.com>,
	David Henningsson <david.henningsson@...onical.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable HP amp and mute LED on HP Folio 9480m

On Wed, 15 Jul 2015 21:14:39 +0200,
Keith Packard wrote:
> 
> Takashi Iwai <tiwai@...e.de> writes:
> 
> > Thanks!  The new patch looks good, but I think we don't have to use
> > the headset code, as your case looks more like a headphone, not a
> > combo headset that needs the special handling.  If so, the change can
> > be reduced something like below.  Could you check whether this is
> > enough?
> 
> Yes, that seems a lot simpler and works fine. I did remove the
> led_power_filter setting; that doesn't seem relevant for GPIO-based
> leds, and isn't necessary on my device in any case.
> 
> This patch is now otherwise essentially the same as yours, with the
> addition of comments.
> 
> Thanks again for your help; it's always interesting to dive into some
> different area of the kernel and see how it works.

Great, I queued the patch now.  It'll be included in the next pull
request for 4.2-rc3.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/